linux-kernel - Re: [patch 1/3] [PATCH] mm: migration -- Do not loose soft dirty bit if page is in migration state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1381241500-bfdgpu61-mutt-n-horiguchi@ah.jp.nec.com>
Date:	Tue, 08 Oct 2013 10:11:40 -0400
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Andy Lutomirski <luto@...capital.net>,
	Matt Mackall <mpm@...enic.com>,
	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Peter Zijlstra <peterz@...radead.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Subject: Re: [patch 1/3] [PATCH] mm: migration -- Do not loose soft dirty bit
 if page is in migration state

On Tue, Oct 08, 2013 at 01:00:20PM +0400, Cyrill Gorcunov wrote:
> If page migration is turne on in the config and the page is migrating,
> we may loose soft dirty bit. If fork and mprotect if called on migrating
> pages (once migration is complete) pages do not obtain soft dirty bit
> in correspond pte entries. Fix it adding appropriate test on swap
> entries.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> Cc: Pavel Emelyanov <xemul@...allels.com>
> Cc: Andy Lutomirski <luto@...capital.net>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
> Cc: Marcelo Tosatti <mtosatti@...hat.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@...il.com>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
> ---
>  mm/memory.c   |    2 ++
>  mm/migrate.c  |    2 ++
>  mm/mprotect.c |    7 +++++--
>  3 files changed, 9 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.git/mm/memory.c
> ===================================================================
> --- linux-2.6.git.orig/mm/memory.c
> +++ linux-2.6.git/mm/memory.c
> @@ -837,6 +837,8 @@ copy_one_pte(struct mm_struct *dst_mm, s
>  					 */
>  					make_migration_entry_read(&entry);
>  					pte = swp_entry_to_pte(entry);
> +					if (pte_swp_soft_dirty(*src_pte))
> +						pte = pte_swp_mksoft_dirty(pte);
>  					set_pte_at(src_mm, addr, src_pte, pte);
>  				}
>  			}

When we convert pte to swap_entry, we convert soft-dirty bit in
pte_to_swp_entry(). So I think that it's better to convert it back
in swp_entry_to_pte() when we do swap_entry-to-pte conversion.

Thanks,
Naoya Horiguchi

> Index: linux-2.6.git/mm/migrate.c
> ===================================================================
> --- linux-2.6.git.orig/mm/migrate.c
> +++ linux-2.6.git/mm/migrate.c
> @@ -161,6 +161,8 @@ static int remove_migration_pte(struct p
>  
>  	get_page(new);
>  	pte = pte_mkold(mk_pte(new, vma->vm_page_prot));
> +	if (pte_swp_soft_dirty(*ptep))
> +		pte = pte_mksoft_dirty(pte);
>  	if (is_write_migration_entry(entry))
>  		pte = pte_mkwrite(pte);
>  #ifdef CONFIG_HUGETLB_PAGE
> Index: linux-2.6.git/mm/mprotect.c
> ===================================================================
> --- linux-2.6.git.orig/mm/mprotect.c
> +++ linux-2.6.git/mm/mprotect.c
> @@ -94,13 +94,16 @@ static unsigned long change_pte_range(st
>  			swp_entry_t entry = pte_to_swp_entry(oldpte);
>  
>  			if (is_write_migration_entry(entry)) {
> +				pte_t newpte;
>  				/*
>  				 * A protection check is difficult so
>  				 * just be safe and disable write
>  				 */
>  				make_migration_entry_read(&entry);
> -				set_pte_at(mm, addr, pte,
> -					swp_entry_to_pte(entry));
> +				newpte = swp_entry_to_pte(entry);
> +				if (pte_swp_soft_dirty(oldpte))
> +					newpte = pte_swp_mksoft_dirty(newpte);
> +				set_pte_at(mm, addr, pte, newpte);
>  			}
>  			pages++;
>  		}
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/