linux-kernel - Re: [PATCH] tpm: xen-tpmfront: fix missing declaration of xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1310081530340.26077@kaball.uk.xensource.com>
Date:	Tue, 8 Oct 2013 15:30:49 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Rob Herring <robherring2@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <stefano.stabellini@...citrix.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>,
	Ashley Lai <ashley@...leylai.com>,
	Rajiv Andrade <mail@...jiv.net>,
	Marcel Selhorst <tpmdd@...horst.net>,
	Sirrix AG <tpmdd@...rix.com>,
	<tpmdd-devel@...ts.sourceforge.net>
Subject: Re: [PATCH] tpm: xen-tpmfront: fix missing declaration of
 xen_domain

On Mon, 7 Oct 2013, Rob Herring wrote:
> From: Rob Herring <rob.herring@...xeda.com>
> 
> xen-tpmfront fails to build on arm64 with the following error:
> 
> drivers/char/tpm/xen-tpmfront.c: In function ‘xen_tpmfront_init’:
> drivers/char/tpm/xen-tpmfront.c:422:2: error: implicit declaration of function ‘xen_domain’ [-Werror=implicit-function-declaration]
> 
> Add include of xen/xen.h to fix this.
> 
> Signed-off-by: Rob Herring <rob.herring@...xeda.com>
> Cc: Leonidas Da Silva Barbosa <leosilva@...ux.vnet.ibm.com>
> Cc: Ashley Lai <ashley@...leylai.com>
> Cc: Rajiv Andrade <mail@...jiv.net>
> Cc: Marcel Selhorst <tpmdd@...horst.net>
> Cc: Sirrix AG <tpmdd@...rix.com>
> Cc: tpmdd-devel@...ts.sourceforge.net

Thanks, added to my queue


>  drivers/char/tpm/xen-tpmfront.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 06189e5..94c280d 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -10,6 +10,7 @@
>  #include <linux/errno.h>
>  #include <linux/err.h>
>  #include <linux/interrupt.h>
> +#include <xen/xen.h>
>  #include <xen/events.h>
>  #include <xen/interface/io/tpmif.h>
>  #include <xen/grant_table.h>
> -- 
> 1.8.1.2
>