linux-kernel - Re: [PATCH v3 10/19] ARM: at91/dt: add system clk id definitions in dt-bindings include dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Oct 2013 17:36:59 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Boris BREZILLON <b.brezillon@...rkiz.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	Andrew Victor <linux@...im.org.za>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	Russell King <linux@....linux.org.uk>,
	Mike Turquette <mturquette@...aro.org>,
	"Felipe Balbi" <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Josh Wu <josh.wu@...el.com>,
	Richard Genoud <richard.genoud@...il.com>
CC:	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 10/19] ARM: at91/dt: add system clk id definitions
 in dt-bindings include dir

On 08/08/2013 08:15, Boris BREZILLON :
> This patch adds system clk ids definitions into dt-bindinds include dir
> (include/dt-bindings/clk/at91/'soc-name'/system-clk.h).
>
> These definitions will be used by dt definition to define and reference
> system clks.

As said earlier, I think that these definitions can be removed. We can 
stick with raw numbers and just document that we are using the offset of 
the coresponding bit in the register.

> Signed-off-by: Boris BREZILLON <b.brezillon@...rkiz.com>
> ---
>   .../dt-bindings/clk/at91/at91rm9200/clk-system.h   |   16 +++++++++++++++
>   .../dt-bindings/clk/at91/at91sam9261/clk-system.h  |   15 ++++++++++++++
>   include/dt-bindings/clk/at91/common/clk-system.h   |   21 ++++++++++++++++++++
>   3 files changed, 52 insertions(+)
>   create mode 100644 include/dt-bindings/clk/at91/at91rm9200/clk-system.h
>   create mode 100644 include/dt-bindings/clk/at91/at91sam9261/clk-system.h
>   create mode 100644 include/dt-bindings/clk/at91/common/clk-system.h
>
> diff --git a/include/dt-bindings/clk/at91/at91rm9200/clk-system.h b/include/dt-bindings/clk/at91/at91rm9200/clk-system.h
> new file mode 100644
> index 0000000..43bccd5
> --- /dev/null
> +++ b/include/dt-bindings/clk/at91/at91rm9200/clk-system.h
> @@ -0,0 +1,16 @@
> +/*
> + * This header provides constants for AT91RM9200 system clocks.
> + *
> + * The constants defined in this header are being used in dts.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_AT91RM9200_SYSTEM_H
> +#define _DT_BINDINGS_CLK_AT91RM9200_SYSTEM_H
> +
> +#include <dt-bindings/clk/at91/common/system-clk.h>
> +
> +#define AT91RM9200_UDP_SYS_CLK		1
> +#define AT91RM9200_MCKUDP_SYS_CLK	2
> +#define AT91RM9200_UHP_SYS_CLK		4
> +
> +#endif
> diff --git a/include/dt-bindings/clk/at91/at91sam9261/clk-system.h b/include/dt-bindings/clk/at91/at91sam9261/clk-system.h
> new file mode 100644
> index 0000000..28a140a
> --- /dev/null
> +++ b/include/dt-bindings/clk/at91/at91sam9261/clk-system.h
> @@ -0,0 +1,15 @@
> +/*
> + * This header provides constants for AT91SAM9261 system clocks.
> + *
> + * The constants defined in this header are being used in dts.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_AT91SAM9261_SYSTEM_H
> +#define _DT_BINDINGS_CLK_AT91SAM9261_SYSTEM_H
> +
> +#include <dt-bindings/clk/at91/common/system-clk.h>
> +
> +#define AT91SAM9261_HCK0_SYS_CLK	16
> +#define AT91SAM9261_HCK1_SYS_CLK	17
> +
> +#endif
> diff --git a/include/dt-bindings/clk/at91/common/clk-system.h b/include/dt-bindings/clk/at91/common/clk-system.h
> new file mode 100644
> index 0000000..c0fb124
> --- /dev/null
> +++ b/include/dt-bindings/clk/at91/common/clk-system.h
> @@ -0,0 +1,21 @@
> +/*
> + * This header provides constants for AT91 system clocks.
> + *
> + * The constants defined in this header are being used in dts.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_AT91_SYSTEM_H
> +#define _DT_BINDINGS_CLK_AT91_SYSTEM_H
> +
> +#define AT91_PCK_SYS_CLK	0
> +#define AT91_DDRCK_SYS_CLK	2
> +#define AT91_LCDCK_SYS_CLK	3
> +#define AT91_SMDCK_SYS_CLK	4
> +#define AT91_UHP_SYS_CLK	6
> +#define AT91_UDP_SYS_CLK	7
> +
> +#define AT91_PROG_SYS_CLK(id)	(8 + id)
> +
> +#define AT91_MAX_SYS_CLKS	32
> +
> +#endif
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/