linux-kernel - Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52544CC1.6010502@gmail.com>
Date:	Tue, 08 Oct 2013 20:19:45 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Jean-Francois Moine <moinejf@...e.fr>,
	Jason Cooper <jason@...edaemon.net>
CC:	Andrew Lunn <andrew@...n.ch>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ARM: Dove: fix bad properties of the si5351 clkout2
 used by Cubox audio

On 10/08/2013 08:20 PM, Jean-Francois Moine wrote:
> As defined in the DT, clkout2 is not allowed to change the pll inside
> si5351.
>
> This patch extends the properties of clkout2 so that it works as the
> external clock of the audio device in the Cubox.
>
> Also, as the second si5351 clock is not used in the Cubox, its
> definition is removed.
>
> Signed-off-by: Jean-Francois Moine <moinejf@...e.fr>

Already gave my

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>

which you should add to help us keep track of them next time.

> ---
> v2:
> - remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)
> ---
>   arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts b/arch/arm/boot/dts/dove-cubox.dts
> index bb38a24..3dd8844 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -99,18 +99,12 @@
>   			silabs,pll-master;
>   		};
>
> -		clkout1 {
> -			reg = <1>;
> -			silabs,drive-strength = <8>;
> -			silabs,multisynth-source = <1>;
> -			silabs,clock-source = <0>;
> -			silabs,pll-master;
> -		};
> -
>   		clkout2 {
>   			reg = <2>;
> +			silabs,drive-strength = <8>;
>   			silabs,multisynth-source = <1>;
>   			silabs,clock-source = <0>;
> +			silabs,pll-master;
>   		};
>   	};
>   };
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/