| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20131008183949.GB23288@kernel.dk> Date: Tue, 8 Oct 2013 12:39:49 -0600 From: Jens Axboe <axboe@...nel.dk> To: Matthew Wilcox <willy@...ux.intel.com> Cc: Matias Bjørling <m@...rling.me>, linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org Subject: Re: [PATCH RFC 0/2] Convert from bio-based to blk-mq On Tue, Oct 08 2013, Matthew Wilcox wrote: > On Tue, Oct 08, 2013 at 11:34:20AM +0200, Matias Bjørling wrote: > > The nvme driver implements itself as a bio-based driver. This primarily because > > of high lock congestion for high-performance nvm devices. To remove the > > congestion, a multi-queue block layer is being implemented. > > Um, no. You'll crater performance by adding another memory allocation > (of the struct request). multi-queue is not the solution. That's a rather "jump to conclusions" statement to make. As Matias mentioned, there are no extra fast path allocations. Once the tagging is converted as well, I'd be surprised if it performs worse than before. And that on top of a net reduction in code. blk-mq might not be perfect as it stands, but it's a helluva lot better than a bunch of flash based drivers with lots of duplicated code and mechanisms. We need to move away from that. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists