linux-kernel - Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131008213642.GB29121@katana>
Date:	Tue, 8 Oct 2013 23:36:43 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Ionut Nicu <ioan.nicu.ext@....com>
Cc:	Peter Korsgaard <peter.korsgaard@...co.com>,
	Alexander Sverdlin <alexander.sverdlin@....com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c-mux-gpio: use deferred probing with the device
 tree

On Tue, Oct 08, 2013 at 03:51:50PM +0200, Ionut Nicu wrote:
> If the i2c-parent bus driver is not loaded, returning
> -EINVAL will force people to unload and then reload the
> module again to get it working.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@....com>

Doesn't the non-DT case need fixing, too?

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d4a99b..eb99f04 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -79,7 +79,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>  	adapter = of_find_i2c_adapter_by_node(adapter_np);
>  	if (!adapter) {
>  		dev_err(&pdev->dev, "Cannot find parent bus\n");
> -		return -ENODEV;
> +		return -EPROBE_DEFER;
>  	}
>  	mux->data.parent = i2c_adapter_id(adapter);
>  	put_device(&adapter->dev);
> -- 
> 1.7.1

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)