linux-kernel - Re: [PATCH 00/16] sched/wait: Collapse __wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Oct 2013 14:43:00 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Ingo Molnar <mingo.kernel.org@...il.com>,
	Oleg Nesterov <oleg@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] sched/wait: Collapse __wait_event macros -v5

On Tue, Oct 08, 2013 at 11:06:07PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 08, 2013 at 01:41:29PM -0700, Paul E. McKenney wrote:
> > On Tue, Oct 08, 2013 at 10:01:55PM +0200, Peter Zijlstra wrote:
> > > On Tue, Oct 08, 2013 at 09:47:18PM +0200, Ingo Molnar wrote:
> > > > To me it would sure look nice to have kernel/rcu/tree.c, 
> > > > kernel/rcu/tiny.c, kernel/rcu/core.c, etc.
> > > > 
> > > > [ ... and we would certainly also break new ground by introducing a
> > > >   "torture.c" file, for the first time in Linux kernel history! ;-) ]
> > > > 
> > > > But it's really your call, this is something you should only do if you are 
> > > > comfortable with it.
> > > 
> > > IFF we're going to restructure rcu; can we save the CPP some work and do
> > > away with rcu*_plugin.h ?
> > 
> > OK, I'll bite...  Where did you want to put the code instead?
> 
> Just about here:
> 
> kernel/rcutree.c:#include "rcutree_plugin.h"
> 
> and save the bother of inclusion.

I would be more likely to break rcutree_plugin.h into pieces (e.g., for
preempt-rcu, RCU_FAST_NOHZ, NOCB, stall warnings, and so on than to merge
it into rcutree.c.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/