linux-kernel - Re: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Oct 2013 15:39:50 +0900
From:	"sangjung.woo" <sangjung.woo@...sung.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	sangjung.woo@...sung.com
Subject: Re: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()

On 10/09/2013 03:20 PM, Joe Perches wrote:
> On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote:
>> Because dev_*() are used along with pr_debug() function in this code,
>> the debug message is not tidy. This patch converts from pr_debug() to
>> dev_dbg() since dev_*() are encouraged to use in device driver code.
> []
>> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> []
>> @@ -57,7 +57,7 @@ static void puv3_rtc_setaie(int to)
>>   {
>>   	unsigned int tmp;
>>   
>> -	pr_debug("%s: aie=%d\n", __func__, to);
>> +	dev_dbg(dev, "%s: aie=%d\n", __func__, to);
> Does this compile?
>
>
Oops! I did not add my local modification into the patch.
The function parameters should be modified as below.

-static void puv3_rtc_setaie(int to)
+static void puv3_rtc_setaie(struct device *dev, int to)


I will send the new one.
Thank you for your good review.

Cheers, Sangjung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/