linux-kernel - Re: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5255012C.3050709@ti.com>
Date:	Wed, 9 Oct 2013 10:09:32 +0300
From:	Roger Quadros <rogerq@...com>
To:	Paul Walmsley <paul@...an.com>
CC:	<tony@...mide.com>, <balbi@...com>, <rnayak@...com>,
	<t-kristo@...com>, <linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: OMAP4: clock: Initialize USB DPLL

On 10/09/2013 10:05 AM, Paul Walmsley wrote:
> Hi Roger,
> 
> On Thu, 21 Mar 2013, Roger Quadros wrote:
> 
>> +Paul
>>
>> On 03/21/2013 03:48 PM, Roger Quadros wrote:
>>> If the bootloader doesn't configure USB DPLL (e.g. in u-boot,
>>> disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems
>>> like
>>> - division by zero errors at boot [1]
>>> - USB DPLL fails to enter locked state
>>> - USB EHCI Host is non functional
>>> - Device can't enter OFF mode
>>>
>>> Initializing the USB DPLL fixes all these issues.
> 
> Looks like I may have lost track of this - do we still need this one?

No, this is already in with the typo fix. Thanks.

> 
> Also:
> 
>>> diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c
>>> index bfc46c1..6127bb9 100644
>>> --- a/arch/arm/mach-omap2/cclock44xx_data.c
>>> +++ b/arch/arm/mach-omap2/cclock44xx_data.c
>>> @@ -53,6 +53,12 @@
>>>   */
>>>  #define OMAP4_DPLL_ABE_DEFFREQ				98304000
>>>  
>>> +/*
>>> + * OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
> 
> 4450?

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/