linux-kernel - Re: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52550447.5070805@ti.com>
Date:	Wed, 9 Oct 2013 12:52:47 +0530
From:	Afzal Mohammed <afzal@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: wakeupgen: AM43x adaptation

Hi Tony,

On Wednesday 09 October 2013 02:54 AM, Tony Lindgren wrote:
> * Afzal Mohammed <afzal@...com> [130905 04:03]:

>> -#define MAX_NR_REG_BANKS	5
>> -#define MAX_IRQS		160
>> +/* maximum value correspond to that of AM43x */
>> +#define MAX_NR_REG_BANKS	7
>> +#define MAX_IRQS		224
>> +#define DEFAULT_NR_REG_BANKS	5
>> +#define DEFAULT_IRQS		160
>>  #define WKG_MASK_ALL		0x00000000
>>  #define WKG_UNMASK_ALL		0xffffffff
>>  #define CPU_ENA_OFFSET		0x400
> 
> How about define it like this to avoid updating things
> in multiple places for new SoCs:
> 
> #define AM43X_NR_REG_BANKS	7
> #define MAX_NR_REG_BANKS	AM43X_NR_REG_BANKS

Yes that is better

>>  	for (i = 0; i < irq_banks; i++) {
>>  		wakeupgen_writel(0, i, CPU0_ID);
>> -		wakeupgen_writel(0, i, CPU1_ID);
>> +		if (!am43x)
>> +			wakeupgen_writel(0, i, CPU1_ID);
>>  	}
> 
> Why not use soc_is_am43xx() directly here?

Ok, it has been changed in the new version.

Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/