linux-kernel - Re: [PATCH 2/5] gpiolib / ACPI: convert to gpiod interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131009080109.GT3521@intel.com>
Date:	Wed, 9 Oct 2013 11:01:09 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Alexandre Courbot <gnurou@...il.com>
Cc:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	rjw@...ysocki.net, Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	Rob Landley <rob@...dley.net>, linux-acpi@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] gpiolib / ACPI: convert to gpiod interfaces

On Tue, Oct 08, 2013 at 09:26:14AM -0700, Alexandre Courbot wrote:
> On Tue, Oct 8, 2013 at 3:36 AM, Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> > On Tue, Oct 08, 2013 at 11:45:08AM +0300, Mika Westerberg wrote:
> >> > I also wonder whether you could also avoid exporting acpi_get_gpiod*
> >> > (which allow GPIO consumers to shortcut gpiolib) by implementing
> >> > acpi_get_gpio* into the C file (maybe even using gpiod_get()). I see a
> >> > "char *path" parameter though, so maybe that would not be possible at
> >> > the moment.
> >>
> >> Good point, I'll check if we can do that.
> >
> > Looks like we can get rid of acpi_get_gpio() and acpi_get_gpiod() as there
> > are no users for those outside gpiolib-acpi. I'm going to do that in the
> > next revision.
> 
> That's good news. If you can make it such that ACPI GPIO consumers
> don't need to include acpi_gpio.h anymore, then this would make my
> day. :)

We can get rid of the whole apci_gpio.h eventually. But before doing that I
would like to have something that supports both the ACPI way and gpiod way
in v3.13 if possible.

Once we have gpiod_get_index() in mainline, we can convert the existing
user to it and drop acpi_gpio.h completely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/