linux-kernel - Re: [PATCH 53/52] tools/perf/build: Clean up feature_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131009083804.GA1005@krava.redhat.com>
Date:	Wed, 9 Oct 2013 10:38:04 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 53/52] tools/perf/build: Clean up feature_print_code()

On Wed, Oct 09, 2013 at 08:42:05AM +0200, Ingo Molnar wrote:

SNIP

> > 
> > I think the issue might be in the eval handling the $(info $(MSG)).
> > With following change on top of your v2 patchset it works for me.
> 
> Indeed - and that works here too. Initially I was trying to solve it by 
> forcing expansion:
> 
> 	MSG := ...
> 
> but I forgot that expansion does not necessarily force evaluation of the 
> expression and that Make can still optimize such assignments away if their 
> result is not used by a target, correct?

I saw that the $(info $(MSG)) output was delayed to next
iteration, that's why an extra item (DUMMY) was needed
to display all of them

so I guessed the eval had issues with $(info ...) and put
it away.. not sure what the actual reason was.. we could
go with your explanation ;-)


> 
> I've applied your cleanup patch below and added your signoff - is that 
> fine with you?

sure, np

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/