[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5255176F.1020700@ti.com>
Date: Wed, 9 Oct 2013 11:44:31 +0300
From: Tomi Valkeinen <tomi.valkeinen@...com>
To: Michal Simek <michal.simek@...inx.com>
CC: <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
Russell King <linux@....linux.org.uk>,
Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
<linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata()
On 03/10/13 12:46, Michal Simek wrote:
> Driver core clears the driver data to NULL after device_release
> or on probe failure, so just remove it from here.
>
> Driver core change:
> "device-core: Ensure drvdata = NULL when no driver is bound"
> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
> drivers/video/amba-clcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c
> index 0a2cce7..0bab6ab 100644
> --- a/drivers/video/amba-clcd.c
> +++ b/drivers/video/amba-clcd.c
> @@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev)
> {
> struct clcd_fb *fb = amba_get_drvdata(dev);
>
> - amba_set_drvdata(dev, NULL);
> -
> clcdfb_disable(fb);
> unregister_framebuffer(&fb->fb);
> if (fb->fb.cmap.len)
> --
> 1.8.2.3
>
Thanks, queued for 3.13.
Tomi
Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)
Powered by blists - more mailing lists