linux-kernel - Re: [PATCH v2 1/3] video: xilinxfb: Use standard variable name convention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52553B9A.6090901@monstr.eu>
Date:	Wed, 09 Oct 2013 13:18:50 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Mark Rutland <mark.rutland@....com>
CC:	Michal Simek <michal.simek@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] video: xilinxfb: Use standard variable name convention

On 10/09/2013 01:06 PM, Mark Rutland wrote:
> On Wed, Oct 09, 2013 at 11:52:12AM +0100, Michal Simek wrote:
>> s/op/pdev/ in xilinxfb_of_probe().
>> No functional chagnes.
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> ---
>> Changes in v2: None
>>
>>  drivers/video/xilinxfb.c | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
>> index 0e1dd33..d12345f 100644
>> --- a/drivers/video/xilinxfb.c
>> +++ b/drivers/video/xilinxfb.c
>> @@ -411,7 +411,7 @@ static int xilinxfb_release(struct device *dev)
>>   * OF bus binding
>>   */
>>
>> -static int xilinxfb_of_probe(struct platform_device *op)
>> +static int xilinxfb_of_probe(struct platform_device *pdev)
>>  {
>>  	const u32 *prop;
>>  	u32 tft_access = 0;
>> @@ -425,7 +425,7 @@ static int xilinxfb_of_probe(struct platform_device *op)
>>  	/* Allocate the driver data region */
>>  	drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL);
>>  	if (!drvdata) {
>> -		dev_err(&op->dev, "Couldn't allocate device private record\n");
>> +		dev_err(&pdev->dev, "Couldn't allocate device private record\n");
>>  		return -ENOMEM;
>>  	}
>>
>> @@ -433,7 +433,7 @@ static int xilinxfb_of_probe(struct platform_device *op)
>>  	 * To check whether the core is connected directly to DCR or BUS
>>  	 * interface and initialize the tft_access accordingly.
>>  	 */
>> -	of_property_read_u32(op->dev.of_node, "xlnx,dcr-splb-slave-if",
>> +	of_property_read_u32(pdev->dev.of_node, "xlnx,dcr-splb-slave-if",
>>  			     &tft_access);
>>
>>  	/*
>> @@ -457,29 +457,29 @@ static int xilinxfb_of_probe(struct platform_device *op)
>>  	}
>>  #endif
>>
>> -	prop = of_get_property(op->dev.of_node, "phys-size", &size);
>> +	prop = of_get_property(pdev->dev.of_node, "phys-size", &size);
>>  	if ((prop) && (size >= sizeof(u32)*2)) {
>>  		pdata.screen_width_mm = prop[0];
>>  		pdata.screen_height_mm = prop[1];
>>  	}
> 
> While you're changing these lines, it would be nice to change this
> pattern (here and elsewhere) to use of_property_read_u32_array, so that
> it's endian-safe and consistent with other devicetree parsing code:
> 
>   of_property_read_u32_array(pdev->dev.of_node, "phys-size", prop, 2);
> 
> It won't read the values if the property data's too short, so that
> should be consistent with the existing code.
> 
> It would also make the diffstat negative :)

The intention of this patch is simple rename which is exactly how
patch should look like. It means one change per patch.

It means these changes you have describe should be in separate patch
and I definitely agree with them.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)