linux-kernel - Re: [PATCH 2/6] rcu: Create rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131009195250.GL13848@laptop.programming.kicks-ass.net>
Date:	Wed, 9 Oct 2013 21:52:50 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jonathan Corbet <corbet@....net>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] rcu: Create rcu_sync infrastructure

On Tue, Oct 08, 2013 at 02:40:45PM -0600, Jonathan Corbet wrote:
> OK, so this is a real nit, but...in the changelog:
> 
> >         static inline void rcu_sync_enter(struct rcu_sync_struct *xxx)
> >         {
> >                 atomic_inc(&xxx->counter);
> >                 synchronize_sched();
> >         }
> > 
> >         static inline void rcu_sync_enter(struct rcu_sync_struct *xxx)
> >         {
> >                 synchronize_sched();
> >                 atomic_dec(&xxx->counter);
> >         }
> 
> That second rcu_sync_enter should really be rcu_sync_exit.
> 
> Is the "xxx" there to test spamassassin configurations? :)

Uhh, no, its a search-n-replace fail, Oleg's original email on the
subject called the entire primitive xxx. I replaced (some) of them with
rcu_sync.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/