[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2013 09:12:56 +0300
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Mark Brown <broonie@...nel.org>
Cc: linux-acpi@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Aaron Lu <aaron.lu@...el.com>, Lv Zheng <lv.zheng@...el.com>,
linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] spi: attach/detach SPI device to the ACPI power
domain
On Wed, Oct 09, 2013 at 06:55:28PM +0100, Mark Brown wrote:
> On Wed, Oct 09, 2013 at 05:04:21PM +0300, Mika Westerberg wrote:
> > If the SPI device is enumerated from ACPI namespace (it has an ACPI handle)
> > it might have ACPI methods that needs to be called in order to transition
> > the device to different power states (such as _PSx).
>
> Acked-by: Mark Brown <broonie@...aro.org>
Thanks!
> > + if (ACPI_HANDLE(&spi->dev))
> > + acpi_dev_pm_attach(&spi->dev, true);
>
> Though I do wonder if it wouldn't be sensible to push the if () here
> inside acpi_dev_pm_attach() and similarly for _detach(). Terribly
> trivial either way.
Actually, the check is already there in acpi_dev_pm_attach()/detach(). The
above code follows what Rafael did for platform bus previously. I think the
idea is to have visual hint that this is only for ACPI enumerated devices.
If preferred, I can drop the if() checks, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists