linux-kernel - Re: [PATCH 07/52] tools/perf/build: Split out feature check: 'volatile-register-var'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 09:03:18 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 07/52] tools/perf/build: Split out feature check:
 'volatile-register-var'


* Namhyung Kim <namhyung@...nel.org> wrote:

> > +test-volatile-register-var:
> > +	$(BUILD) -Werror -Wvolatile-register-var
> 
> I'm not sure this test is necessary at all.
> 
> The gcc manpage says this warning is enabled by -Wall, and we add -Wall 
> to CFLAGS before doing feature checks.  So all gcc versions that support 
> -Wvolatile-register-var enables it by default without this check and 
> older gcc versions will always fail the feature check.

Good point - I'll send a patch to remove it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/