[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 10 Oct 2013 12:43:07 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Peter De Schrijver <pdeschrijver@...dia.com>
Cc: Mike Turquette <mturquette@...aro.org>,
Stephen Warren <swarren@...dotorg.org>,
Rob Herring <rob.herring@...xeda.com>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ian.campbell@...rix.com>,
Prashant Gaikwad <pgaikwad@...dia.com>,
Paul Walmsley <pwalmsley@...dia.com>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-tegra@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/5] clk: tegra: Add periph regs bank X
On Fri, Oct 04, 2013 at 12:12:41PM +0300, Peter De Schrijver wrote:
> Tegra124 has an extra bank of peripheral clock registers. Add it to the
> generic peripheral clock code.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@...dia.com>
> ---
> drivers/clk/tegra/clk.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
> index c8c84ce..0240dc3 100644
> --- a/drivers/clk/tegra/clk.c
> +++ b/drivers/clk/tegra/clk.c
> @@ -57,6 +57,8 @@
> #define RST_DEVICES_CLR_V 0x434
> #define RST_DEVICES_SET_W 0x438
> #define RST_DEVICES_CLR_W 0x43c
> +#define RST_DEVICES_SET_X 0x290
> +#define RST_DEVICES_CLR_X 0x294
Perhaps sort these numerically rather than alphabetically? Also I don't
see where the CLK_OUT_ENB_X, CLK_OUT_ENB_{SET,CLR}_X or RST_DEVICES_X
registers are defined. Perhaps they were part of some other patch or a
series that this depends on?
>
> /* Global data of Tegra CPU CAR ops */
> static struct tegra_cpu_car_ops dummy_car_ops;
> @@ -109,6 +111,14 @@ static struct tegra_clk_periph_regs periph_regs[] = {
> .rst_set_reg = RST_DEVICES_SET_W,
> .rst_clr_reg = RST_DEVICES_CLR_W,
> },
> + [5] = {
> + .enb_reg = CLK_OUT_ENB_X,
> + .enb_set_reg = CLK_OUT_ENB_SET_X,
> + .enb_clr_reg = CLK_OUT_ENB_CLR_X,
> + .rst_reg = RST_DEVICES_X,
> + .rst_set_reg = RST_DEVICES_SET_X,
> + .rst_clr_reg = RST_DEVICES_CLR_X,
> + },
> };
Thierry
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists