linux-kernel - Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 09:33:10 -0400
From:	Vaibhav Bedia <vaibhav.bedia@...il.com>
To:	joelf@...com
Cc:	Nishanth Menon <nm@...com>, devicetree@...r.kernel.org,
	Paul Walmsley <paul@...an.com>,
	Kevin Hilman <khilman@...aro.org>, linux-doc@...r.kernel.org,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	Tero Kristo <t-kristo@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Benoit Cousson <bcousson@...libre.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for
 calling pm late init

Hi Joel.

On Thu, Oct 10, 2013 at 1:32 AM, Joel Fernandes <joelf@...com> wrote:
> On 10/09/2013 06:24 PM, Nishanth Menon wrote:
>> Call OMAP2+ generic lateinit hook from AM specific late init hook.
>> This allows the generic late initializations such as cpufreq hooks
>> to be active.
>>
>> Cc: Benoit Cousson <bcousson@...libre.com>
>> Cc: Kevin Hilman <khilman@...prootsystems.com>
>> Cc: Paul Walmsley <paul@...an.com>
>> Cc: Tony Lindgren <tony@...mide.com>
>> Signed-off-by: Nishanth Menon <nm@...com>
>> ---
>>  arch/arm/mach-omap2/board-generic.c |    1 +
>>  arch/arm/mach-omap2/common.h        |    1 +
>>  arch/arm/mach-omap2/io.c            |    6 ++++++
>>  3 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
>> index 87162e1..b474498 100644
>> --- a/arch/arm/mach-omap2/board-generic.c
>> +++ b/arch/arm/mach-omap2/board-generic.c
>> @@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
>>       .init_irq       = omap_intc_of_init,
>>       .handle_irq     = omap3_intc_handle_irq,
>>       .init_machine   = omap_generic_init,
>> +     .init_late      = am33xx_init_late,
>
> Instead of adding a new a *_init_late function for every platform, perhaps
> better to just do:
> .init_late      = omap2_common_pm_late_init;
>
> since that's the only function you're calling.
>
For now...

As the PM support gets added there will be other function calls
and that can and is at times soc specific.

Regards,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/