linux-kernel - Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 21:43:54 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Ionut Nicu <ioan.nicu.ext@....com>,
	Peter Korsgaard <peter.korsgaard@...co.com>,
	Alexander Sverdlin <alexander.sverdlin@....com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c-mux-gpio: test if the gpio can sleep

On Thu, Oct 10, 2013 at 10:46:41AM +0200, Lars-Peter Clausen wrote:

> > +		if (gpio_cansleep(gpio))
> > +			gpio_set_value_cansleep(gpio, val & (1 << i));
> > +		else
> > +			gpio_set_value(gpio, val & (1 << i));
> 
> The proper way to do this is just always use the _cansleep() version.
> gpio_set_value() only works for chips which do not sleep,
> gpio_set_value_cansleep() works for both those who do sleep and those who do
> not.

To the gpio-list: Has it been considered to have sth. like
gpio_set_value and gpio_set_value_nosleep? I'd think it makes more sense
to have the specific function have the specific name.

Regards,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)