linux-kernel - Re: [PATCH V5 3/3] drivers/rtc/rtc-as3722: add RTC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Oct 2013 23:47:48 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Laxman Dewangan <ldewangan@...dia.com>, lee.jones@...aro.org,
	sameo@...ux.intel.com, linus.walleij@...aro.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	rtc-linux@...glegroups.com, rob.herring@...xeda.com,
	mark.rutland@....com, pawel.moll@....com, swarren@...dotorg.org,
	rob@...dley.net, ijc+devicetree@...lion.org.uk,
	grant.likely@...aro.org,
	Florian Lobmaier <florian.lobmaier@....com>
Subject: Re: [PATCH V5 3/3] drivers/rtc/rtc-as3722: add RTC driver

On Thu, Oct 10, 2013 at 03:24:46PM -0700, Andrew Morton wrote:
> On Wed, 9 Oct 2013 17:59:21 +0530 Laxman Dewangan <ldewangan@...dia.com> wrote:

> > +config RTC_DRV_AS3722
> > +	tristate "ams AS3722 RTC driver"
> > +	depends on MFD_AS3722

> ... the rtc patch depends on an mfd patch, so everyone ends up sitting
> around looking at everyone else, wondering who will merge it all.

With the MFD ones providing you trust the interfaces with the core
are going to be OK there's no problem to just merge them via individual
trees - the dependency on the MFD will prevent bisection problems.

> > +#ifdef CONFIG_PM
> 
> Most (but not all!) rtc drivers use CONFIG_PM_SLEEP.  People have madly
> mucked with CONFIG_PM* and I don't know the difference and I don't know
> what's going on and I don't know of a convenient place to go to find
> out.  If you work it out, please be sure to tell me!  But as soon as I
> figure it out I'm sure they'll go and madly muck with it again.

The two effective options for this stuff are PM_SLEEP (for system
suspend) and PM_RUNTIME (for runtime suspend which RTCs are unlikely to
use I guess).  PM mostly just enables selection of the other two.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)