linux-kernel - Re: tty: incorrect test of echo_buf() result for ECHO_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52588005.4030806@hurleysoftware.com>
Date:	Fri, 11 Oct 2013 18:47:33 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Roel Kluin <roel.kluin@...il.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: tty: incorrect test of echo_buf() result for ECHO_OP_START

On 10/11/2013 04:08 PM, Roel Kluin wrote:
> Untested, but this looks like a bug to me

Careless error on my part. Fix looks good; thanks for catching this.

Regards,
Peter Hurley

> -----------
> test echo_buf() result for ECHO_OP_START
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 7a744b6..42b6cca 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -767,7 +767,7 @@ static size_t __process_echoes(struct tty_struct *tty)
>   	 * of echo overrun before the next commit), then discard enough
>   	 * data at the tail to prevent a subsequent overrun */
>   	while (ldata->echo_commit - tail >= ECHO_DISCARD_WATERMARK) {
> -		if (echo_buf(ldata, tail == ECHO_OP_START)) {
> +		if (echo_buf(ldata, tail) == ECHO_OP_START) {
>   			if (echo_buf(ldata, tail) == ECHO_OP_ERASE_TAB)
>   				tail += 3;
>   			else

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/