linux-kernel - Re: [PATCH] KEYS: Fix a race between negating a key and reading the error set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7165.1381531906@warthog.procyon.org.uk>
Date:	Fri, 11 Oct 2013 23:51:46 +0100
From:	David Howells <dhowells@...hat.com>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	dhowells@...hat.com, jmorris@...ei.org,
	Scott Mayhew <smayhew@...hat.com>, keyrings@...ux-nfs.org,
	Dave Wysochanski <dwysocha@...hat.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] KEYS: Fix a race between negating a key and reading the error set

Jeff Layton <jlayton@...hat.com> wrote:

> > -		if (kflags & (1 << KEY_FLAG_NEGATIVE))
> > +		if (kflags & (1 << KEY_FLAG_NEGATIVE)) {
> 
> Not specifically related to this bug, but why are you open-coding
> test_bit() here and elsewhere?

Because kflags is read once and kept in a variable.  Might not be necessary -
and I should probably use ACCESS_ONCE() when I do.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/