linux-kernel - RE: [patch x86/hyperv] x86, hyperv: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86627d477ccc42aea289f62ad96d0e4b@SN2PR03MB061.namprd03.prod.outlook.com>
Date:	Fri, 11 Oct 2013 23:16:09 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	David Rientjes <rientjes@...gle.com>,
	Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
CC:	Olaf Hering <olaf@...fle.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: RE: [patch x86/hyperv] x86, hyperv: Fix build error



> -----Original Message-----
> From: David Rientjes [mailto:rientjes@...gle.com]
> Sent: Friday, October 11, 2013 4:08 PM
> To: Ingo Molnar; H. Peter Anvin; tglx@...utronix.de; H. Peter Anvin
> Cc: KY Srinivasan; Olaf Hering; linux-kernel@...r.kernel.org; linux-tip-
> commits@...r.kernel.org
> Subject: [patch x86/hyperv] x86, hyperv: Fix build error
> 
> 9e7827b5ea4c ("x86, hyperv: Get the local APIC timer frequency from the
> hypervisor") breaks the build with some configs because apic.h isn't
> directly included:
> 
> arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform':
> arch/x86/kernel/cpu/mshyperv.c:90:3: error: 'lapic_timer_frequency' undeclared
> (first use in this function)
> arch/x86/kernel/cpu/mshyperv.c:90:3: note: each undeclared identifier is
> reported only once for each function it appears in
> 
> Fix it by including asm/apic.h.

Thank you. The issue was configuration related - local APIC was not configured. This has already been fixed.

Regards.

K. Y
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  arch/x86/kernel/cpu/mshyperv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -25,6 +25,7 @@
>  #include <asm/idle.h>
>  #include <asm/irq_regs.h>
>  #include <asm/i8259.h>
> +#include <asm/apic.h>
> 
>  struct ms_hyperv_info ms_hyperv;
>  EXPORT_SYMBOL_GPL(ms_hyperv);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/