linux-kernel - Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131011065149.GA16470@localhost>
Date:	Fri, 11 Oct 2013 14:51:49 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jakub Jelinek <jakub@...hat.com>,
	Richard Henderson <rth@...ddle.net>,
	Peter Zijlstra <peterz@...radead.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto'
 miscompilation bug

On Fri, Oct 11, 2013 at 07:46:55AM +0200, Ingo Molnar wrote:
> 
> * Fengguang Wu <fengguang.wu@...el.com> wrote:
> 
> > > Indeed. Something like the updated version below?
> > > 
> > > [ I kept the asm_volatile_goto() naming to make sure the implicit volatile 
> > >   is visible. ]
> > 
> > Ingo, I applied this patch (as commit c015a7f0b746) on top of 
> > tip/sched/core
> > 
> >         3354781a2184 "sched/numa: Reflow task_numa_group() to avoid a compiler warning"
> > 
> > The below results show that it does fixed the many oops:
> 
> Thanks Fengguang!
> 
> I've added your Tested-by tag as well and have split the patch in two 
> parts: the upstream part with a -stable tag and the rmwcc.h part that goes 
> into the scheduler tree.
> 
> If there are no objections I will send a pull request for the upstream 
> part to Linus later today.

Ingo, sorry I'm still waiting for more results to arrive so as to confirm
whether the below "kernel_early_hang_without_any_printk_output" is a noise or
reliably caused by the gcc patch:

+-------------------------------------------------+--------------+--------------+
|                                                 | 3354781a2184 | c015a7f0b746 |
+-------------------------------------------------+--------------+--------------+
| good_boots                                      | 9            | 8            |
| BUG:kernel_early_hang_without_any_printk_output | 0            | 1            |
+-------------------------------------------------+--------------+--------------+

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/