linux-kernel - Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV8rgy=_njpXcWuZ6zkB_Lox2k0tPJy7x1Vb7ZyGN-q5g@mail.gmail.com>
Date:	Fri, 11 Oct 2013 09:08:14 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Peter Jones <pjones@...hat.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Matt Fleming <matt@...sole-pimps.org>,
	linux-efi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

On Thu, Oct 10, 2013 at 8:09 PM, Peter Jones <pjones@...hat.com> wrote:
> INTN
> GetPixelElementSize (
> IN EFI_PIXEL_BITMASK *PixelBits
> )
> {
>         INTN HighestPixel = -1;
>         INTN BluePixel;
>         INTN RedPixel;
>         INTN GreenPixel;
>         INTN RsvdPixel;
>         BluePixel = FindHighestSetBit (PixelBits->BlueMask);
>         RedPixel = FindHighestSetBit (PixelBits->RedMask);
>         GreenPixel = FindHighestSetBit (PixelBits->GreenMask);
>         RsvdPixel = FindHighestSetBit (PixelBits->ReservedMask);
>         HighestPixel = max (BluePixel, RedPixel);
>         HighestPixel = max (HighestPixel, GreenPixel);
>         HighestPixel = max (HighestPixel, RsvdPixel);
>         return HighestPixel;
> }
> EFI_PHYSICAL_ADDRESS NewPixelAddress;
> EFI_PHYSICAL_ADDRESS CurrentPixelAddress;
> EFI_GRAPHICS_OUTPUT_MODE_INFORMATION OutputInfo;
> INTN PixelElementSize;
>
> switch (OutputInfo.PixelFormat) {
>         case PixelBitMask:
>                 PixelElementSize = GetPixelElementSize (&OutputInfo.PixelInformation);

So this can be less than 32.

>                 break;
>         case PixelBlueGreenRedReserved8BitPerColor:
>         case PixelRedGreenBlueReserved8BitPerColor:
>                 PixelElementSize = sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL);
>                 break;
> }
>
> Which makes this painfully clear.
>
>> Also, the main question would be, what is the typical value for
>> si->lfb_depth. 32 on almost all EFI systems? All around the map? Depends
>> on what graphics state the EFI bootloader passes us?
>
> Yes, 32 on almost all systems that implement a framebuffer console at
> all.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/