linux-kernel - Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131011071430.GD6847@bbox>
Date:	Fri, 11 Oct 2013 16:14:30 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Weijie Yang <weijie.yang@...sung.com>, sjenning@...ux.vnet.ibm.com,
	bob.liu@...cle.com, weijie.yang.kh@...il.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	d.j.shin@...sung.com, heesub.shin@...sung.com,
	kyungmin.park@...sung.com, hau.chen@...sung.com,
	bifeng.tong@...sung.com, rui.xie@...sung.com
Subject: Re: [PATCH v3 3/3] mm/zswap: avoid unnecessary page scanning

On Thu, Oct 10, 2013 at 12:55:06PM -0700, Andrew Morton wrote:
> On Mon, 23 Sep 2013 16:21:49 +0800 Weijie Yang <weijie.yang@...sung.com> wrote:
> 
> > add SetPageReclaim before __swap_writepage so that page can be moved to the
> > tail of the inactive list, which can avoid unnecessary page scanning as this
> > page was reclaimed by swap subsystem before.
> > 
> > Signed-off-by: Weijie Yang <weijie.yang@...sung.com>
> > Reviewed-by: Bob Liu <bob.liu@...cle.com>
> > Cc: Minchan Kim <minchan@...nel.org>
> > Cc: stable@...r.kernel.org
> > Acked-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>
> 
> As a minor(?) performance tweak, I don't believe this is suitable for
> -stable backporting, so I took that out.  If you believe this was a
> mistake, please explain why.
> 

Yes. It's never stable stuff.

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/