linux-kernel - Re: [PATCH 092/100] xen/hvc: allow xenboot console to be used again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877gdkcbla.fsf@canonical.com>
Date:	Fri, 11 Oct 2013 12:04:49 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	David Vrabel <david.vrabel@...rix.com>
Cc:	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
	<kernel-team@...ts.ubuntu.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH 092/100] xen/hvc: allow xenboot console to be used again

David Vrabel <david.vrabel@...rix.com> writes:

> On 11/10/13 11:42, Luis Henriques wrote:
>> 3.5.7.23 -stable review patch.  If anyone has any objections, please let me know.
>
> It's harmless to backport this, but it is only needed in 3.10 and later
> (unless you've backported d0380e6c).

Ups, you're right.  I'll drop this from the 3.5 queue.  Thanks!

Cheers,
-- 
Luis


>
>> From: David Vrabel <david.vrabel@...rix.com>
>> 
>> commit a9fbf4d591da6cd1d3eaab826c7c15f77fc8f6a3 upstream.
>> 
>> Commit d0380e6c3c0f6edb986d8798a23acfaf33d5df23 (early_printk:
>> consolidate random copies of identical code) added in 3.10 introduced
>> a check for con->index == -1 in early_console_register().
>> 
>> Initialize index to -1 for the xenboot console so earlyprintk=xen
>> works again.
>> 
>> Signed-off-by: David Vrabel <david.vrabel@...rix.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Jiri Slaby <jslaby@...e.cz>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Signed-off-by: Luis Henriques <luis.henriques@...onical.com>
>> ---
>>  drivers/tty/hvc/hvc_xen.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
>> index 944eaeb..78873df 100644
>> --- a/drivers/tty/hvc/hvc_xen.c
>> +++ b/drivers/tty/hvc/hvc_xen.c
>> @@ -634,6 +634,7 @@ struct console xenboot_console = {
>>  	.name		= "xenboot",
>>  	.write		= xenboot_write_console,
>>  	.flags		= CON_PRINTBUFFER | CON_BOOT | CON_ANYTIME,
>> +	.index		= -1,
>>  };
>>  #endif	/* CONFIG_EARLY_PRINTK */
>>  
>
> David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/