linux-kernel - Re: [PATCH 1/2] i2c-mux-gpio: use gpio_set_value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wqlkgij4.fsf@thor.barco.com>
Date:	Fri, 11 Oct 2013 13:21:19 +0200
From:	Peter Korsgaard <peter.korsgaard@...co.com>
To:	Ionut Nicu <ioan.nicu.ext@....com>
CC:	Wolfram Sang <wsa@...-dreams.de>,
	Alexander Sverdlin <alexander.sverdlin@....com>,
	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

>>>>> "IN" == Ionut Nicu <ioan.nicu.ext@....com> writes:

IN> Some gpio chips may have get/set operations that
IN> can sleep. gpio_set_value() only works for chips
IN> which do not sleep, for the others we will get a
IN> kernel warning. Using gpio_set_value_cansleep()
IN> will work for both chips that do sleep and those
IN> who don't.

IN> Signed-off-by: Ionut Nicu <ioan.nicu.ext@....com>
IN> ---
IN>  drivers/i2c/muxes/i2c-mux-gpio.c |    4 ++--
IN>  1 files changed, 2 insertions(+), 2 deletions(-)

IN> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
IN> index a764da7..550e094 100644
IN> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
IN> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
IN> @@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
IN>     int i;

IN>     for (i = 0; i < mux->data.n_gpios; i++)
IN> -           gpio_set_value(mux->gpio_base + mux->data.gpios[i],
IN> -                          val & (1 << i));
IN> +           gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
IN> +                           val & (1 << i));

The indentation of the 2nd line seems wrong (should match
mux->gpio_base), otherwise it looks good:

Acked-by: Peter Korsgaard <peter.korsgaard@...co.com>

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/