lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Oct 2013 15:03:12 +0200 From: Richard Weinberger <richard@....at> To: Will Deacon <will.deacon@....com> CC: Richard Weinberger <richard.weinberger@...il.com>, Chen Gang <gang.chen@...anux.com>, Martin Schwidefsky <schwidefsky@...ibm.com>, Heiko Carstens <heiko.carstens@...ibm.com>, Russell King - ARM Linux <linux@....linux.org.uk>, Catalin Marinas <Catalin.Marinas@....com>, "linux390@...ibm.com" <linux390@...ibm.com>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] arm/arm64: remove atomic_clear_mask() in "include/asm/atomic.h" Am 11.10.2013 14:28, schrieb Will Deacon: > On Fri, Oct 11, 2013 at 01:08:17PM +0100, Richard Weinberger wrote: >> On Fri, Oct 11, 2013 at 1:47 PM, Chen Gang <gang.chen@...anux.com> wrote: >>> In current kernel wide source code, except other architectures, only >>> s390 scsi drivers use atomic_clear_mask(), and arm/arm64 need not >>> support s390 drivers. >>> >>> So remove atomic_clear_mask() from "arm[64]/include/asm/atomic.h". >> >> Is it really worth removing such a primitive? >> If someone needs it later he has to implement it from scratch and >> introduces bugs... > > The version we have (on ARM64 anyway) already has bugs. Given the choice > between fixing code that has no callers and simply removing it, I'd go for > the latter. Yeah, if it's broken and has no real users, send it to hell. :) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists