| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1381498368.19281.15.camel@empanada> Date: Fri, 11 Oct 2013 08:32:48 -0500 From: Tom Zanussi <tom.zanussi@...ux.intel.com> To: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> Cc: rostedt@...dmis.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE On Fri, 2013-10-11 at 22:00 +0900, Masami Hiramatsu wrote: > (2013/10/11 9:48), Tom Zanussi wrote: > > If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined, > > resulting in an 'undefined reference' error - define a stub to remedy > > that. > > > > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com> > > Hmm, what kernel config caused that error? > It seems that the CONFIG_STACKTRACE is forced on if it is required. > And if you have found such case, IMHO, we should turn on the CONFIG_STACKTRACE > in Kconfig. Yeah, it's not easy to turn off CONFIG_STACKTRACE - I basically had to tweak a couple Kconfigs to do it, so I could test my stacktrace trigger CONFIG_STACKTRACE ifdefs. Still, it's code that explicitly depends on CONFIG_STACKTRACE, so I think it makes sense to ifdef it. Tom > (Also, if it is not related to this series, it should be reported as a separated > bugfix :) ) > > Thank you, > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists