linux-kernel - Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Oct 2013 08:39:52 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<b.zolnierkie@...sung.com>, <m.szyprowski@...sung.com>,
	<andrzej.p@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers
 support

Hi,

On Fri, Oct 11, 2013 at 08:23:35AM +0200, Robert Baldyga wrote:
> Hello,
> 
> On 10/10/2013 06:04 PM, Felipe Balbi wrote:
> > Hi,
> > 
> > On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote:
> >> @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >>  	s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps);
> >>  
> >>  	/* default, set to non-periodic */
> >> +	hs_ep->isochronous = 0;
> >>  	hs_ep->periodic = 0;
> >>  	hs_ep->halted = 0;
> > 
> > this hunk doesn't apply because of this hs_ep->halted line, which patch
> > does this depend on ?
> > 
> it depends on http://www.spinics.net/lists/linux-usb/msg94025.html

I'll fix it up by hand this time, but new features shouldn't (ideally)
directly depend on fixes which you just wrote.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)