linux-kernel - Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1381521888.15023.8.camel@pippen.local.home>
Date:	Fri, 11 Oct 2013 16:04:48 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if
 !CONFIG_STACKTRACE

On Fri, 2013-10-11 at 08:32 -0500, Tom Zanussi wrote:

> Yeah, it's not easy to turn off CONFIG_STACKTRACE - I basically had to
> tweak a couple Kconfigs to do it, so I could test my stacktrace trigger
> CONFIG_STACKTRACE ifdefs.

If there's no way to do make it fail currently, then it's not really a
problem.

> 
> Still, it's code that explicitly depends on CONFIG_STACKTRACE, so I
> think it makes sense to ifdef it.
> 

If we do decided to do this, then the change belongs in
include/kernel.h:

+#ifdef CONFIG_STACKTRACE
 extern void trace_dump_stack(int skip);
+#else
+static inline void trace_dump_stack(int skip) { }
+#endif

But again, since CONFIG_TRACING can't be configured without
CONFIG_STACKTRACE, I don't believe this change needs to be added.

You can keep it a separate patch locally to your tree for debugging, but
I doesn't need to be upstream.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/