linux-kernel - [PATCH] blk-mq: cache rq->q

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131011041105.GA1692@kernel.org>
Date:	Fri, 11 Oct 2013 12:11:05 +0800
From:	Shaohua Li <shli@...nel.org>
To:	linux-kernel@...r.kernel.org, axboe@...nel.dk
Subject: [PATCH] blk-mq: cache rq->q


If a tag is freed, the request might be used very soon. There is a short window
rq->q is null, so cache it.

Signed-off-by: Shaohua Li <shli@...ionio.com>
---
 block/blk-mq.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: master/block/blk-mq.c
===================================================================
--- master.orig/block/blk-mq.c	2013-10-11 12:07:32.282133638 +0800
+++ master/block/blk-mq.c	2013-10-11 12:07:32.282133638 +0800
@@ -250,11 +250,12 @@ static void __blk_mq_free_request(struct
 				  struct blk_mq_ctx *ctx, struct request *rq)
 {
 	const int tag = rq->tag;
+	struct request_queue *q = rq->q;
 
 	blk_mq_rq_init(hctx, rq);
 	blk_mq_put_tag(hctx->tags, tag);
 
-	blk_mq_queue_exit(rq->q);
+	blk_mq_queue_exit(q);
 }
 
 void blk_mq_free_request(struct request *rq)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/