linux-kernel - Re: [Question]should we not ignore the masked interrupt in regmap?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131012123217.GK2443@sirena.org.uk>
Date:	Sat, 12 Oct 2013 13:32:17 +0100
From:	Mark Brown <broonie@...nel.org>
To:	yi zhang <yizhang.mrvl@...il.com>
Cc:	Yi Zhang <yizhang@...vell.com>, zhouqiao@...vell.com,
	zhangwm@...vell.com, linux-kernel@...r.kernel.org
Subject: Re: [Question]should we not ignore the masked interrupt in regmap?

On Sat, Oct 12, 2013 at 11:14:27AM +0800, yi zhang wrote:

> 1) interrupt is triggered;
> 2) a thread disables it(then the mask bit is set);
> 3) _Then_ the interrupt thread is executed, it _ignore _ and doesn’t
> handle this interrupt;
>    because the interrupt is not ACKed, the interrupt status is not cleared;
> 4) in Marvell's PMIC, the interrupt line to SOC is always asserted,
> then irq storm happens;

This sounds like you need the workaround activated by init_ack_masked.
It's basically the hardware failing to implement masking sensibly - the
general expectation for a mask bit is that it will have no effect on the
actual state of the interrupt, only on if it's reported.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)