| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 12 Oct 2013 13:58:59 -0300 From: Ezequiel García <ezequiel@...guardiasur.com.ar> To: Daniel Mack <zonque@...il.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-input@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com> Subject: Re: [PATCH v2 1/2] Input: rotary-encoder: Add 'stepped' irq handler Dmitry, On 4 October 2013 10:18, Daniel Mack <zonque@...il.com> wrote: > On 04.10.2013 14:53, Ezequiel Garcia wrote: >> Some rotary-encoder devices (such as those with detents) are capable >> of producing a stable event on each step. This commit adds support >> for this case, by implementing a new interruption handler. >> >> The handler needs only detect the direction of the turn and generate >> an event according to this detection. > > I think you can squash patch 2/2 into this one. It doesn't make much > sense to have a one-liner patch to just update the documenation separately. > > Other than that, the code looks fine to me. > > Acked-by: Daniel Mack <zonque@...il.com> > Could you merge these two patches? It's already acked by Daniel, and there wasn't any other feedback so I think we're ready to get them in and support more devices :-) -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists