linux-kernel - Re: [PATCH] cpufreq: fix false return check from "regulator_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKohpokPpyZNN=aH=u8kxDjiQrsE2mwu=0MN6pkWfuXLu9cZKw@mail.gmail.com>
Date:	Sat, 12 Oct 2013 08:51:22 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Manish Badarkhe <badarkhe.manish@...il.com>
Cc:	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	rjw@...k.pl, kgene.kim@...sung.com
Subject: Re: [PATCH] cpufreq: fix false return check from "regulator_set_voltage"

On 09/10/2013, Manish Badarkhe <badarkhe.manish@...il.com> wrote:
> Currently, code checks false return value from "regulator_set_voltage"
> to show failure message. Modify the code to check proper return
> value from "regulator_set_voltage".
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@...il.com>
> ---
> Based on master branch of linux-mainline.
>
> :100644 100644 0fac344... 1537f32... M	drivers/cpufreq/exynos-cpufreq.c
>  drivers/cpufreq/exynos-cpufreq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c
> b/drivers/cpufreq/exynos-cpufreq.c
> index 0fac344..1537f32 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -141,7 +141,7 @@ post_notify:
>  	if ((freqs.new < freqs.old) ||
>  	   ((freqs.new > freqs.old) && safe_arm_volt)) {
>  		/* down the voltage after frequency change */
> -		regulator_set_voltage(arm_regulator, arm_volt,
> +		ret = regulator_set_voltage(arm_regulator, arm_volt,
>  				arm_volt);
>  		if (ret) {
>  			pr_err("%s: failed to set cpu voltage to %d\n",

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/