linux-kernel - Re: [PATCH] drivers/base/core.c: always output device renaming messages.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABawtvNbiLXWcoP+RJUkxzXdECmSubwfhcMazrvJTrAytFs0tg@mail.gmail.com>
Date:	Sun, 13 Oct 2013 09:34:57 +0800
From:	Ethan Zhao <ethan.kernel@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/base/core.c: always output device renaming messages.

On Sun, Oct 13, 2013 at 1:50 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sat, Oct 12, 2013 at 02:52:51PM +0800, Ethan Zhao wrote:
>> >> --- a/drivers/base/core.c
>> >> +++ b/drivers/base/core.c
>> >> @@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
>> >>       if (!dev)
>> >>               return -EINVAL;
>> >>
>> >> -     pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
>> >> -              __func__, new_name);
>> >> +     dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);
>> >
>> > How about:
>> >         dev_dbg(dev, "renaming to '%s'\n", new_name);
>>
>> If something confusing or wrong, need to take a look.
>> For pr_debug(), We have to build and load a debug kernel…
>> For dev_dbg(),  We have to rebuild a kernel with CONFIG_DYNAMIC_DEBUG
>> set to 'y', that is default 'n'.
>
> Why would you not enable that option these days?  All distros enable it,
> and if you should too :)
>
Okey, let them enable it in the Linux distribution.

Thanks,
Ethan

>> So, do you mean
>>
>> dev_printk(KERN_DEBUG, dev, "renaming to '%s'\n", new_name);  ?
>
> No, dev_dbg();.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/