linux-kernel - Re: [PATCH] init: fix in-place parameter modification regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eh7o8ft4.fsf@rustcorp.com.au>
Date:	Mon, 14 Oct 2013 18:06:23 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Krzysztof Mazur <krzysiek@...lesie.net>,
	linux-kernel@...r.kernel.org
Cc:	Pawel Moll <pawel.moll@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Krzysztof Mazur <krzysiek@...lesie.net>
Subject: Re: [PATCH] init: fix in-place parameter modification regression

Krzysztof Mazur <krzysiek@...lesie.net> writes:
> Before commit 026cee0086fe1df4cf74691cf273062cc769617d
> ("params: <level>_initcall-like kernel parameters") the __setup
> parameter parsing code could modify parameter in the
> static_command_line buffer and such modifications were kept. After
> that commit such modifications are destroyed during per-initcall level
> parameter parsing because the same static_command_line buffer is used
> and only parameters for appropriate initcall level are parsed.
>
> That change broke at least parsing "ubd" parameter in the ubd driver
> when the COW file is used.
>
> Now the separate buffer is used for per-initcall parameter parsing,
> like in parsing early params.

How about just removing "strcpy(static_command_line, saved_command_line);"
from do_initcall_level altogether?  We already initialize it in
setup_command_line().

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/