linux-kernel - Re: [tip:x86/kaslr] x86, relocs: Add more per-cpu gold special cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131014093826.GA22177@gmail.com>
Date:	Mon, 14 Oct 2013 11:38:27 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	hpa@...or.com, linux-kernel@...r.kernel.org, keescook@...omium.org,
	md@...gle.com, tglx@...utronix.de, hpa@...ux.intel.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/kaslr] x86, relocs: Add more per-cpu gold special cases


* Ingo Molnar <mingo@...nel.org> wrote:

> * tip-bot for Michael Davidson <tipbot@...or.com> wrote:
> 
> > Commit-ID:  d751c169e9a6f0f853346f1184881422bd10b3c2
> > Gitweb:     http://git.kernel.org/tip/d751c169e9a6f0f853346f1184881422bd10b3c2
> > Author:     Michael Davidson <md@...gle.com>
> > AuthorDate: Thu, 10 Oct 2013 18:39:54 -0700
> > Committer:  H. Peter Anvin <hpa@...ux.intel.com>
> > CommitDate: Sun, 13 Oct 2013 03:11:57 -0700
> > 
> > x86, relocs: Add more per-cpu gold special cases
> 
> I'm quite sure that one of the recent x86/kaslr changes causes this 
> early x86-64 crash:

excluding tip:x86/kaslr fixes the crash. So it's one of these commits:

6e6a4932b0f5 x86, boot: Rename get_flags() and check_flags() to *_cpuflags()
6145cfe394a7 x86, kaslr: Raise the maximum virtual address to -1 GiB on x86_64
f32360ef6608 x86, kaslr: Report kernel offset on panic
82fa9637a2ba x86, kaslr: Select random position from e820 maps
5bfce5ef55cb x86, kaslr: Provide randomness functions
8ab3820fd5b2 x86, kaslr: Return location from decompress_kernel
dd78b97367bd x86, boot: Move CPU flags out of cpucheck
d751c169e9a6 x86, relocs: Add more per-cpu gold special cases

One guess would be:

 dd78b97367bd x86, boot: Move CPU flags out of cpucheck

That commit is crazy large - it should be done in at least two steps:

 - first the movement to cpuflags.c
 - the PIC-safe refactoring

Also, checking:

 82fa9637a2ba x86, kaslr: Select random position from e820 maps

I see:

 +#ifdef CONFIG_X86_64
 +#define memptr long
 +#else
 +#define memptr unsigned
 +#endif

wtf? That should really be cleaned up while we are touching that code.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/