linux-kernel - Re: [PATCH] regmap: irq: clear status when disable irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131014110908.GP2443@sirena.org.uk>
Date:	Mon, 14 Oct 2013 12:09:08 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Yi Zhang <yizhang@...vell.com>
Cc:	qiaozhou@...vell.com, zhangwm@...vell.com, yizhang.mrvl@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: irq: clear status when disable irq

On Mon, Oct 14, 2013 at 12:23:53PM +0800, Yi Zhang wrote:

> Change-Id: I371201f365c5a8470073a393068cfeb4e3d14a03

Don't include noise like this in upstream submissions.

> +		/* Ack masked but set interrupts */
> +		reg = d->chip->status_base +
> +			(i * map->reg_stride * d->irq_reg_stride);
> +		ret = regmap_read(d->map, reg, &d->status_buf[i]);
> +		if (ret != 0)
> +			dev_err(d->map->dev, "Failed to read IRQ status: %d\n",
> +				ret);

No, this isn't good - it'll read the hardware interrupt status again.
This will break any devices that are clear on read since enabled
interrupts will also be read.  I'd suggest unconditionally acknowledging
all masked interrupts as the simplest approach, obviously it'd be better
to only acknowledge newly masked interrupts but that is more complex to
implement.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)