| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <20131014165249.7b8b2f9e@amdc308.digital.local>
Date: Mon, 14 Oct 2013 16:52:49 +0200
From: Lukasz Majewski <l.majewski@...sung.com>
To: Eduardo Valentin <eduardo.valentin@...com>
Cc: Zhang Rui <rui.zhang@...el.com>, kgene.kim@...sung.com,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Linux PM list <linux-pm@...r.kernel.org>,
Jonghwa Lee <jonghwa3.lee@...sung.com>,
Lukasz Majewski <l.majewski@...ess.pl>,
linux-kernel <linux-kernel@...r.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Tomasz Figa <t.figa@...sung.com>,
Myungjoo Ham <myungjoo.ham@...sung.com>,
devicetree@...r.kernel.org,
Amit Daniel Kachhap <amit.daniel@...sung.com>,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2 2/5] thermal: exynos: Provide separate TMU data for
Exynos4412
Hi Eduardo,
> On 09-10-2013 02:29, Lukasz Majewski wrote:
> > Up till now Exynos5250 and Exynos4412 had the same definitions for
> > TMU data. Following commit changes that, by introducing separate
> > exynos4412_default_tmu_data structure.
> >
> > Since Exynos4412 was chronologically first, the corresponding name
> > for TMU registers and default data was renamed.
> >
> > Additionally, new SOC_ARCH_EXYNOS4412 type has been defined.
> >
> > Moreover, the SOC_ARCH_EXYNOS name has been changed to
> > SOC_ARCH_EXYNOS5250.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski@...sung.com>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > Reviewed-by: Tomasz Figa <t.figa@...sung.com>
> >
> > ---
> > Changes for v2:
> > - Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250
> > - Fix coding style for tmu_data elements definition
> >
> > drivers/thermal/samsung/exynos_tmu.c | 9 +++++----
> > drivers/thermal/samsung/exynos_tmu.h | 3 ++-
> > drivers/thermal/samsung/exynos_tmu_data.c | 28
> > ++++++++++++++++++++++------
> > drivers/thermal/samsung/exynos_tmu_data.h | 9 ++++++++- 4 files
> > changed, 37 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c
> > b/drivers/thermal/samsung/exynos_tmu.c index b43afda..1312b34 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -488,7 +488,7 @@ static const struct of_device_id
> > exynos_tmu_match[] = { },
> > {
> > .compatible = "samsung,exynos4412-tmu",
> > - .data = (void *)EXYNOS5250_TMU_DRV_DATA,
> > + .data = (void *)EXYNOS4412_TMU_DRV_DATA,
> > },
> > {
> > .compatible = "samsung,exynos5250-tmu",
> > @@ -629,9 +629,10 @@ static int exynos_tmu_probe(struct
> > platform_device *pdev) if (ret)
> > return ret;
> >
> > - if (pdata->type == SOC_ARCH_EXYNOS ||
> > - pdata->type == SOC_ARCH_EXYNOS4210 ||
> > - pdata->type == SOC_ARCH_EXYNOS5440)
> > + if (pdata->type == SOC_ARCH_EXYNOS4210 ||
> > + pdata->type == SOC_ARCH_EXYNOS4412 ||
> > + pdata->type == SOC_ARCH_EXYNOS5250 ||
> > + pdata->type == SOC_ARCH_EXYNOS5440)
> > data->soc = pdata->type;
> > else {
> > ret = -EINVAL;
> > diff --git a/drivers/thermal/samsung/exynos_tmu.h
> > b/drivers/thermal/samsung/exynos_tmu.h index b364c9e..b42ece4 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.h
> > +++ b/drivers/thermal/samsung/exynos_tmu.h
> > @@ -41,7 +41,8 @@ enum calibration_mode {
> >
> > enum soc_type {
> > SOC_ARCH_EXYNOS4210 = 1,
> > - SOC_ARCH_EXYNOS,
> > + SOC_ARCH_EXYNOS4412,
> > + SOC_ARCH_EXYNOS5250,
> > SOC_ARCH_EXYNOS5440,
> > };
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu_data.c
> > b/drivers/thermal/samsung/exynos_tmu_data.c index 9002499..d8de5c1
> > 100644 --- a/drivers/thermal/samsung/exynos_tmu_data.c
> > +++ b/drivers/thermal/samsung/exynos_tmu_data.c
> > @@ -90,8 +90,8 @@ struct exynos_tmu_init_data const
> > exynos4210_default_tmu_data = { };
> > #endif
> >
> > -#if defined(CONFIG_SOC_EXYNOS5250) ||
> > defined(CONFIG_SOC_EXYNOS4412) -static const struct
> > exynos_tmu_registers exynos5250_tmu_registers = { +#if
> > defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250)
>
> Below will be only 4412 definitions,right? Why should we test for
> 5250?
^^^^^^^^ [1]
Below are registers definitions for Exynos4412, which appeared first.
However, the Exynos5250 is reusing those registers.
The exact separation between Exynos4412 and Exynos5250 is done when we
assign value to .tmu_data at exynos4412_default_tmu_data and
exynos5250_default_tmu_data.
The test [1] is correct here.
>
> > +static const struct exynos_tmu_registers exynos4412_tmu_registers
> > = { .triminfo_data = EXYNOS_TMU_REG_TRIMINFO,
> > .triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT,
> > .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
> > @@ -128,7 +128,7 @@ static const struct exynos_tmu_registers
> > exynos5250_tmu_registers = { .emul_time_mask =
> > EXYNOS_EMUL_TIME_MASK, };
> >
> > -#define EXYNOS5250_TMU_DATA \
> > +#define EXYNOS4412_TMU_DATA \
> > .threshold_falling = 10, \
> > .trigger_levels[0] = 85, \
> > .trigger_levels[1] = 103, \
> > @@ -162,15 +162,31 @@ static const struct exynos_tmu_registers
> > exynos5250_tmu_registers = { .temp_level = 103, \
> > }, \
> > .freq_tab_count = 2, \
> > - .type = SOC_ARCH_EXYNOS, \
> > - .registers = &exynos5250_tmu_registers, \
> > + .registers = &exynos4412_tmu_registers, \
> > .features = (TMU_SUPPORT_EMULATION |
> > TMU_SUPPORT_TRIM_RELOAD | \ TMU_SUPPORT_FALLING_TRIP |
> > TMU_SUPPORT_READY_STATUS | \ TMU_SUPPORT_EMUL_TIME)
> > +#endif
> >
> > +#if defined(CONFIG_SOC_EXYNOS4412)
> > +struct exynos_tmu_init_data const exynos4412_default_tmu_data = {
> > + .tmu_data = {
> > + {
> > + EXYNOS4412_TMU_DATA,
> > + .type = SOC_ARCH_EXYNOS4412,
> > + },
> > + },
> > + .tmu_count = 1,
> > +};
> > +#endif
> > +
> > +#if defined(CONFIG_SOC_EXYNOS5250)
> > struct exynos_tmu_init_data const exynos5250_default_tmu_data = {
> > .tmu_data = {
> > - { EXYNOS5250_TMU_DATA },
> > + {
> > + EXYNOS4412_TMU_DATA,
> > + .type = SOC_ARCH_EXYNOS5250,
> > + },
> > },
> > .tmu_count = 1,
> > };
> > diff --git a/drivers/thermal/samsung/exynos_tmu_data.h
> > b/drivers/thermal/samsung/exynos_tmu_data.h index dc7feb5..b130b1e
> > 100644 --- a/drivers/thermal/samsung/exynos_tmu_data.h
> > +++ b/drivers/thermal/samsung/exynos_tmu_data.h
> > @@ -138,7 +138,14 @@ extern struct exynos_tmu_init_data const
> > exynos4210_default_tmu_data; #define EXYNOS4210_TMU_DRV_DATA (NULL)
> > #endif
> >
> > -#if (defined(CONFIG_SOC_EXYNOS5250) ||
> > defined(CONFIG_SOC_EXYNOS4412)) +#if defined(CONFIG_SOC_EXYNOS4412)
> > +extern struct exynos_tmu_init_data const
> > exynos4412_default_tmu_data; +#define EXYNOS4412_TMU_DRV_DATA
> > (&exynos4412_default_tmu_data) +#else
> > +#define EXYNOS4412_TMU_DRV_DATA (NULL)
> > +#endif
> > +
> > +#if defined(CONFIG_SOC_EXYNOS5250)
> > extern struct exynos_tmu_init_data const
> > exynos5250_default_tmu_data; #define EXYNOS5250_TMU_DRV_DATA
> > (&exynos5250_default_tmu_data) #else
> >
>
>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists