linux-kernel - Re: [PATCH 3.12-rc4] cifs: ntstatus_to_dos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131014113838.4feb90f5@tlielax.poochiereds.net>
Date:	Mon, 14 Oct 2013 11:38:38 -0400
From:	Jeff Layton <jlayton@...hat.com>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
	linux-kernel@...r.kernel.org, Steve French <sfrench@...ba.org>
Subject: Re: [PATCH 3.12-rc4] cifs: ntstatus_to_dos_map[] is not terminated

On Sun, 13 Oct 2013 13:29:03 -0600
Tim Gardner <tim.gardner@...onical.com> wrote:

> Functions that walk the ntstatus_to_dos_map[] array could
> run off the end. For example, ntstatus_to_dos() loops
> while ntstatus_to_dos_map[].ntstatus is not 0. Granted,
> this is mostly theoretical, but could be used as a DOS attack
> if the error code in the SMB header is bogus.
> 
> Cc: Steve French <sfrench@...ba.org>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---
>  fs/cifs/netmisc.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
> index af847e1..651a527 100644
> --- a/fs/cifs/netmisc.c
> +++ b/fs/cifs/netmisc.c
> @@ -780,7 +780,9 @@ static const struct {
>  	ERRDOS, ERRnoaccess, 0xc0000290}, {
>  	ERRDOS, ERRbadfunc, 0xc000029c}, {
>  	ERRDOS, ERRsymlink, NT_STATUS_STOPPED_ON_SYMLINK}, {
> -	ERRDOS, ERRinvlevel, 0x007c0001}, };
> +	ERRDOS, ERRinvlevel, 0x007c0001}, {
> +	0, 0, 0 }
> +};
>  
>  /*****************************************************************************
>   Print an error message from the status code

Nice catch.

Reviewed-by: Jeff Layton <jlayton@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/