linux-kernel - Re: [PATCH v3 08/10] intel_mid: Added custom handler for ipc devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <525C1CDE.9020309@linux.intel.com>
Date:	Mon, 14 Oct 2013 09:33:34 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	x86@...nel.org, platform-driver-x86@...r.kernel.org,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@...ux.intel.com>
Subject: Re: [PATCH v3 08/10] intel_mid: Added custom handler for ipc devices

On 10/14/2013 09:04 AM, H. Peter Anvin wrote:
> On 10/11/2013 08:43 PM, David Cohen wrote:
>> +
>> +	/*
>> +	 * We need to call platform init of IPC devices to fill misc_pdata
>> +	 * structure. It will be used in msic_init for initialization.
>> +	 */
>> +	if (dev != NULL)
>> +		pdata = dev->get_platform_data(pentry);
>> +
>
> The Linux style usually prefers:
>
> 	if (dev)

Thanks. I'll change it on next patch set.

Br, David Cohen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/