linux-kernel - Re: [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 14 Oct 2013 09:47:00 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	x86@...nel.org, platform-driver-x86@...r.kernel.org,
	Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@...ux.intel.com>
Subject: Re: [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c

On 10/14/2013 09:38 AM, H. Peter Anvin wrote:
> On 10/11/2013 08:43 PM, David Cohen wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
>>
>> Moved SFI specific parsing/handling code to intel_mid_sfi.c. This will enable
>> us to reuse our intel-mid code for platforms that supports firmware interfaces
>> other than SFI (like ACPI).
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>
>> Signed-off-by: David Cohen <david.a.cohen@...ux.intel.com>
>> ---
>>   arch/x86/include/asm/intel-mid.h            |   1 +
>>   arch/x86/platform/intel-mid/Makefile        |   5 +-
>>   arch/x86/platform/intel-mid/intel-mid.c     | 450 --------------------------
>>   arch/x86/platform/intel-mid/intel_mid_sfi.c | 485 ++++++++++++++++++++++++++++
>>   4 files changed, 489 insertions(+), 452 deletions(-)
>>   create mode 100644 arch/x86/platform/intel-mid/intel_mid_sfi.c
>>
>
> Why not just sfi.c?  It is already in a directly named intel-mid.
>
> I presume otherwise this is just code movement... I haven't verified
> that, but it looked like it.

Yes, it is and I agree sfi.c seems better. Changing it for next patch
set too.

Br, David Cohen

>
> 	-hpa
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/