linux-kernel - Re: [PATCH 2/2 for 3.12-rc6] Revert "partitions/efi: account for pmbr size in lba"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131014112642.8efe63022ea05b07ced7fad8@linux-foundation.org>
Date:	Mon, 14 Oct 2013 11:26:42 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Davidlohr Bueso <davidlohr@...com>,
	Matt Fleming <matt.fleming@...el.com>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	Karel Zak <kzak@...hat.com>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>,
	Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH 2/2 for 3.12-rc6] Revert
 "partitions/efi: account for pmbr size in lba"

On Mon, 14 Oct 2013 14:41:49 +0300 Artem Bityutskiy <dedekind1@...il.com> wrote:

> This reverts commit 27a7c642174eaec627f6a3a254035bf8abd02c5e.
> 
> This patch breaks existing systems, for example, Tizen IVI images do not boot
> the way they have always been booted because of this patch.

Does Doug's patch fix this?


From: Doug Anderson <dianders@...omium.org>
Subject: block/partitions/efi.c: treat size mismatch as a warning, not an error

In 27a7c64 ("partitions/efi: account for pmbr size in lba") we started
treating bad sizes in lba field of the partition that has the 0xEE (GPT
protective) as errors.  However, we may run into these "bad sizes" in the
real world if someone uses dd to copy an image from a smaller disk to a
bigger disk.  Since this case used to work (even without using force_gpt),
keep it working and treat the size mismatch as a warning instead of an
error.

Reported-by: Josh Triplett <josh@...htriplett.org>
Reported-by: Sean Paul <seanpaul@...omium.org>
Signed-off-by: Doug Anderson <dianders@...omium.org>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
Acked-by: Davidlohr Bueso <davidlohr@...com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 block/partitions/efi.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff -puN block/partitions/efi.c~block-partitions-efic-treat-size-mismatch-as-a-warning-not-an-error block/partitions/efi.c
--- a/block/partitions/efi.c~block-partitions-efic-treat-size-mismatch-as-a-warning-not-an-error
+++ a/block/partitions/efi.c
@@ -222,11 +222,16 @@ check_hybrid:
 	 * the disk size.
 	 *
 	 * Hybrid MBRs do not necessarily comply with this.
+	 *
+	 * Consider a bad value here to be a warning to support dd'ing
+	 * an image from a smaller disk to a larger disk.
 	 */
 	if (ret == GPT_MBR_PROTECTIVE) {
 		sz = le32_to_cpu(mbr->partition_record[part].size_in_lba);
 		if (sz != (uint32_t) total_sectors - 1 && sz != 0xFFFFFFFF)
-			ret = 0;
+			pr_debug("GPT: mbr size in lba (%u) different than whole disk (%u).\n",
+				 sz, min_t(uint32_t,
+					   total_sectors - 1, 0xFFFFFFFF));
 	}
 done:
 	return ret;
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/