linux-kernel - Re: USB regression in v3.12-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131014190539.GI3132@radagast>
Date:	Mon, 14 Oct 2013 14:05:39 -0500
From:	Felipe Balbi <balbi@...com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Aaro Koskinen <aaro.koskinen@....fi>, Felipe Balbi <balbi@...com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<b-liu@...com>
Subject: Re: USB regression in v3.12-rc4

Hi,

On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> > Hi,
> > 
> > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> > (peripheral, g_ether).
> > 
> > According to git bisect this is caused by:
> > 
> > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> > commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> > Author: Bin Liu <b-liu@...com>
> > Date:   Tue Sep 17 15:33:35 2013 -0500
> > 
> >     usb: musb: gadget: fix otg active status flag
> > 
> >     In gadget mode, musb->is_active should be set only when connected to the
> >     host. musb_g_reset() already takes care of it.
> > 
> >     Signed-off-by: Bin Liu <b-liu@...com>
> >     Signed-off-by: Felipe Balbi <balbi@...com>
> > 
> > Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> > commit log this is not fixing any real issue, so I wonder why was it
> > included in -rc4 in the first place?
> 
> Hm, Felipe, should I just revert this patch for 3.12-final?

Yeah, let's do that... It's unfortunate that tusb6010 is so messed up
:-(

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)