linux-kernel - Re: [PATCH] usb/hcd: remove unnecessary local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1310141545430.6851-100000@netrider.rowland.org>
Date:	Mon, 14 Oct 2013 15:48:18 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michael Opdenacker <michael.opdenacker@...e-electrons.com>
cc:	gregkh@...uxfoundation.org, <sarah.a.sharp@...ux.intel.com>,
	<tianyu.lan@...el.com>, <broonie@...aro.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/hcd: remove unnecessary local_irq_save

On Mon, 14 Oct 2013, Michael Opdenacker wrote:

> Hi Alan,
> 
> On 10/13/2013 05:35 PM, Alan Stern wrote:
> > On Sun, 13 Oct 2013, Michael Opdenacker wrote:
> >
> >> Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since
> >> interrupt handlers are always run with interrupts disabled on the
> >> current CPU.
> >>
> >> Tested successfully with 3.12.0-rc4 on my PC. Didn't find
> >> any issue because of this change.
> >>
> >> Signed-off-by: Michael Opdenacker <michael.opdenacker@...e-electrons.com>
> >> ---
> >>  drivers/usb/core/hcd.c | 15 ---------------
> >>  1 file changed, 15 deletions(-)
> > How about removing all the other unnecessary usages of IRQF_DISABLED
> > under drivers/usb while you're at it?
> I believe I already did, through patches sent on Oct. 6:
> 
> drivers/usb/gadget/mv_u3d_core.c:               IRQF_DISABLED |
> IRQF_SHARED, driver_name, u3d)) {
> => Sent fix on Oct. 6, 2013
> 
> drivers/usb/host/uhci-platform.c:       ret = usb_add_hcd(hcd,
> pdev->resource[1].start, IRQF_DISABLED |
> => Sent fix on Oct. 6, 2013

Ah, I had forgotten about those submissions.  No further objections.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/