linux-kernel - Re: [PATCH 2/4] drivers/mmc/host: don't use devm_pinctrl_get_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <l3g6e9$fqh$1@ger.gmane.org>
Date:	Mon, 14 Oct 2013 07:28:09 +0000 (UTC)
From:	Romain Izard <romain.izard.pro@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/4] drivers/mmc/host: don't use
 devm_pinctrl_get_select_default() in probe

On 2013-10-13, Wolfram Sang <wsa@...-dreams.de> wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@...aro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> ---
>  drivers/mmc/host/mvsdio.c          | 7 +------
>  drivers/mmc/host/omap_hsmmc.c      | 7 -------
>  drivers/mmc/host/sdhci-esdhc-imx.c | 8 --------
>  3 files changed, 1 insertion(+), 21 deletions(-)
>
> diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c
> index 06c5b0b..8c9f448 100644
> --- a/drivers/mmc/host/mvsdio.c
> +++ b/drivers/mmc/host/mvsdio.c
> @@ -25,7 +25,6 @@
>  #include <linux/of_irq.h>
>  #include <linux/mmc/host.h>
>  #include <linux/mmc/slot-gpio.h>
> -#include <linux/pinctrl/consumer.h>
>  
>  #include <asm/sizes.h>
>  #include <asm/unaligned.h>
> @@ -685,7 +684,7 @@ static int __init mvsd_probe(struct platform_device *pdev)
>  	const struct mbus_dram_target_info *dram;
>  	struct resource *r;
>  	int ret, irq;
> -	struct pinctrl *pinctrl;
> +	int gpio_card_detect, gpio_write_protect;
>  

This new line does not belong to this patch.

>  	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	irq = platform_get_irq(pdev, 0);
> @@ -702,10 +701,6 @@ static int __init mvsd_probe(struct platform_device *pdev)
>  	host->mmc = mmc;
>  	host->dev = &pdev->dev;
>  
> -	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -	if (IS_ERR(pinctrl))
> -		dev_warn(&pdev->dev, "no pins associated\n");
> -
>  	/*
>  	 * Some non-DT platforms do not pass a clock, and the clock
>  	 * frequency is passed through platform_data. On DT platforms,

Best regards,
-- 
Romain Izard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/