linux-kernel - Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <006b01cec93e$c00a2a10$401e7e30$%han@samsung.com>
Date:	Tue, 15 Oct 2013 09:37:38 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Maximilian Güntner' 
	<maximilian.guentner@...il.com>
Cc:	'Bryan Wu' <cooloney@...il.com>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'linux-leds' <linux-leds@...r.kernel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] leds: Added driver for the NXP PCA9685 I2C chip

On Tuesday, October 15, 2013 2:32 AM, Maximilian Guntner wrote:
> 
> The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095
> levels of brightness)
> This driver supports configuration using platform_data.
> 
> Signed-off-by: Maximilian Güntner <maximilian.guentner@...il.com>

I added some nit-picking comments. :-)

> ---
>  drivers/leds/Kconfig                       |  10 ++
>  drivers/leds/Makefile                      |   1 +
>  drivers/leds/leds-pca9685.c                | 219 +++++++++++++++++++++++++++++
>  include/linux/platform_data/leds-pca9685.h |  34 +++++
>  4 files changed, 264 insertions(+)
>  create mode 100644 drivers/leds/leds-pca9685.c
>  create mode 100644 include/linux/platform_data/leds-pca9685.h
> 

[.....]

> +
> +#include <linux/module.h>
> +#include <linux/string.h>
> +#include <linux/delay.h>
> +#include <linux/ctype.h>
> +#include <linux/leds.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/workqueue.h>
> +#include <linux/slab.h>
> +
> +#include <linux/platform_data/leds-pca9685.h>

Please, sort these header inclusions alphabetically for
better readability.

[.....]

> +#ifndef __LINUX_PCA9685_H
> +#define __LINUX_PCA9685_H

You can add one empty line here.

> +#include <linux/leds.h>
> +

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/